-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve custom filters readability with optional chaining #1275
refactor: improve custom filters readability with optional chaining #1275
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ManikantaMandala thanks, just left one comment and also update PR title to make it more informative as later it lands as a commit message in master
@ManikantaMandala please followup with failing tests. Next time, you better run them locally to make sure they pass, otherwise you will have to do this test ping pong with maintainers and wait for GitHub Actions to run tests for you |
change the file to the suggestions Co-authored-by: Lukasz Gornicki <[email protected]>
Thank you for the feedback @derberg and also can you suggest where to refer to test it locally if possible |
@ManikantaMandala errors happen even if you make PR number 100, no worries test run is visible in https://github.com/asyncapi/generator/actions/runs/11219255311/job/31244271269?pr=1275 and yes, run locally as described in development guide - if they pass locally, please share the log in this PR for overview |
@ManikantaMandala because of a merge of one PR, you have conflicts here now, so please solve them and push updates to the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove changes from eslintrc
solved merge conflits for merging master branch
96eac67
to
e9ed098
Compare
Quality Gate passedIssues Measures |
/rtm |
Description
refactor customFilter.js file mentioned here: these_issues
also mentioned in this issue #1272