refactor: optimize dockerfile for AsyncAPI generator setup #1286
Conversation
Light13008
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
Light13008
changed the title
- Moved the ARG instruction inside the build stage where it is used. - Surrounded $ASYNCAPI_GENERATOR_VERSION with double quotes to prevent word splitting and globbing issues. - Improved maintainability and reliability by ensuring proper variable handling.
This reverts commit 0fc7853.
This reverts commit c95b953.
apps/generator/Dockerfile
Outdated
| FROM node:18-alpine | ||
|
|
||
| ARG ASYNCAPI_GENERATOR_VERSION="1.10.9" # Include ARG in the build stage and surround it with double quotes |
There was a problem hiding this comment.
Pls. remove these unwanted comments
apps/generator/Dockerfile
Outdated
| # Installing latest released npm package | ||
| RUN npm install -g @asyncapi/generator@$ASYNCAPI_GENERATOR_VERSION | ||
| RUN apk --update add --no-cache git chromium && \ | ||
| npm install -g @asyncapi/generator@"$ASYNCAPI_GENERATOR_VERSION" && \ # Surround variable with double quotes |
There was a problem hiding this comment.
From here also, pls. remove extra commnets
|
Description
-I tried to solve this issue