Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize dockerfile #1298

Closed
wants to merge 4 commits into from
Closed

perf: optimize dockerfile #1298

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af9d83f
improve generate function structure
thebedigupta Oct 10, 2024
750f1f2
add comment and surround only the variable
thebedigupta Oct 16, 2024
4cfe688
Merge branch 'master' into pref/dockerfile-optimization
derberg Oct 21, 2024
0420a04
Merge branch 'master' into pref/dockerfile-optimization
asyncapi-bot Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions apps/generator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
ARG ASYNCAPI_GENERATOR_VERSION=1.10.9

FROM node:18-alpine

WORKDIR /app
Expand All @@ -8,14 +6,17 @@ WORKDIR /app
ENV PUPPETEER_EXECUTABLE_PATH /usr/bin/chromium-browser
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true

# Include the ARG instruction in this build stage
ARG ASYNCAPI_GENERATOR_VERSION=1.10.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include one line comment explaining why it should be included in build stage


# Since 0.30.0 release Git is supported and required as a dependency
# Since 0.14.0 release of html-template chromium is needed for pdf generation.
# More custom packages for specific template should not be added to this dockerfile. Instead, we should come up with some extensibility solution.
RUN apk --update add git chromium && \
rm -rf /var/lib/apt/lists/* && \
rm /var/cache/apk/*
# The --no-cache prevents from caching of the package index which saves space by not storing the APK cache files.
# Install dependencies and AsyncAPI Generator in a single RUN command
RUN apk --no-cache add git chromium && \
rm -rf /var/cache/apk/* && \
npm install -g --ignore-scripts "@asyncapi/generator@${ASYNCAPI_GENERATOR_VERSION}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonar was just suggesting to surround only the variable name with double quotes

# Installing latest released npm package
RUN npm install -g @asyncapi/generator@$ASYNCAPI_GENERATOR_VERSION

ENTRYPOINT [ "ag" ]
Loading