-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: better readability of buildLineCore
filter
#1301
refactor: better readability of buildLineCore
filter
#1301
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thebedigupta please read carefully suggestions from sonarcloud. This was not what was advised, using old way of strings concatenation is not a solution.
I get your point and sorry for the mistake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great now
buildLineCore
filter
Quality Gate passedIssues Measures |
/rtm |
Description
In this PR I solved this issue
captured test results test-results.md
Resolved