Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better readability of buildLineCore filter #1301

Merged

Conversation

thebedigupta
Copy link
Contributor

Description

In this PR I solved this issue

captured test results test-results.md

Resolved

  • Removed nested template literals and replaced them with string concatenation

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: fcbecd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@Gmin2 Gmin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thebedigupta please read carefully suggestions from sonarcloud. This was not what was advised, using old way of strings concatenation is not a solution.

@thebedigupta
Copy link
Contributor Author

@thebedigupta please read carefully suggestions from sonarcloud. This was not what was advised, using old way of strings concatenation is not a solution.

I get your point and sorry for the mistake

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great now

@derberg derberg changed the title refactor: using nested template literals refactor: better readability of buildLineCore filter Oct 15, 2024
Copy link

@derberg
Copy link
Member

derberg commented Oct 15, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 25c4e53 into asyncapi:master Oct 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants