Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated sonar test link #1311

Closed
wants to merge 3 commits into from

Conversation

toffee-k21
Copy link

Description

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: b90f68a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better just do apps/generator/test/**/* ?

@toffee-k21
Copy link
Author

apps/generator/test/**/*

Hey @derberg, I've updated the directory path as you suggested. Could you take a look and confirm if everything looks correct?

Copy link

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you didn't do it as I suggested, also sonar.test.inclusions - why this instead of sonar.exclusions

@derberg
Copy link
Member

derberg commented Dec 11, 2024

no followup from contributor - closing PR, we do not want to keep such inactive PRs open

you can restart the work anytime you want, you or any other contributor - just feel free to open another PR. You see previous comments, you know what has to be improved

@derberg derberg closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants