Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add components and helpers packages and show example template #1315

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

derberg
Copy link
Member

@derberg derberg commented Oct 30, 2024

NOT TO BE RELEASED

As stated in readme under packages, this is highly experimental.

Detailed description of PR is in https://github.com/asyncapi/generator/pull/1315/files#diff-1206c4b8d1f7e37d1a4079860d4b24c3178398a059b3bd4c0df5c40fabaab45a that should stay in the source code as guidance for future developments.

This PR has also some haves to apps/generator but only in tests related to react, to showcase usage of new components package.

Related: #1269

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: acccf89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Nov 4, 2024
@aeworxet
Copy link

aeworxet commented Nov 4, 2024

@asyncapi/bounty_team

@derberg
Copy link
Member Author

derberg commented Nov 19, 2024

components idea is kinda there, although I think it should end up in new packages location where I think templates should be.

so far exploring below - but need few days to finalize actually working JS websocket client

Screenshot 2024-11-19 at 21 35 17

@derberg
Copy link
Member Author

derberg commented Nov 20, 2024

just pushed a very simple js websocket client implementation in a new special template structure

now I think next steps are to:

  • try to do python websocket client and see if there will be a possible reusability across languages
  • try to do js mqtt client and see if there will be a possible reusability across protocols

and yeah above should kinda prove that the structure and granularity that is part of it make sense

long way ahead

@derberg
Copy link
Member Author

derberg commented Dec 16, 2024

No activity in PR doesn't mean no work. I consulted with other community folks in #generator channel in Slack:

  • idea of @asyncapi/generator library
  • idea of structured templates in the repo, instead of app per template
  • exploring what we can do to merge such PoC to master without releasing

@derberg derberg changed the title feat: add components library chore: add components and helpers packages and show example template Dec 16, 2024
@derberg derberg marked this pull request as ready for review December 16, 2024 22:02
magicmatatjahu
magicmatatjahu previously approved these changes Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants