Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade @asyncapi/parser to v2.0.0 and use the new parser-api #960

Merged
merged 25 commits into from
May 18, 2023
Merged

feat: upgrade @asyncapi/parser to v2.0.0 and use the new parser-api #960

merged 25 commits into from
May 18, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented May 2, 2023 •
edited
Loading

Replaces #833

Description

Use Parser-JS v2, and new Custom Schema Parsers:

  • add new template config field apiVersion.
  • update relevant source code to handle new and old API
  • add some utils
  • update tests

Related issue(s)
Resolves #825
Part of asyncapi/parser-js#481

@smoya smoya changed the title Chore/update parsers feat: upgrade @asyncapi/parser to v2.0.0 and use the new parser-api May 2, 2023
@smoya smoya mentioned this pull request May 2, 2023
Closed
derberg
derberg previously approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, generator config prop is needed. Basically imagine we do what @fmvilas mentioned in the other comment, that we make v2 default and release 2.0, without generator prop in the template, template users instead of clear info "that template is not compatible with 2.0" they will get some parser errors.

great work, probably https://github.com/asyncapi/generator/blob/master/test/__mocks__/%40asyncapi/parser.js can be removed

@smoya smoya dismissed stale reviews from derberg and fmvilas via dbb27c4 May 12, 2023 19:09
derberg
derberg previously approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
If there are no new comments before Wednesday feel free to merge on Wednesday

@derberg
Copy link
Member

derberg commented May 15, 2023

@Florence-Njeri @pratik2315 please have a look on docs changes, your approval is required

@smoya
Copy link
Member Author

smoya commented May 17, 2023 •
edited
Loading

If there are no new comments before Wednesday feel free to merge on Wednesday

No comments since then, so I'm gonna merge this

@smoya
Copy link
Member Author

smoya commented May 17, 2023

/rtm

@derberg
Copy link
Member

derberg commented May 17, 2023

@smoya you can't merge until @Florence-Njeri or @pratik2315 approves

@smoya
Copy link
Member Author

smoya commented May 17, 2023

@smoya you can't merge until @Florence-Njeri or @pratik2315 approves

Yeah, I feel like an adventurer today 😅

@smoya smoya requested a review from derberg May 18, 2023 10:59
@smoya smoya requested a review from Florence-Njeri May 18, 2023 10:59
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya
Copy link
Member Author

smoya commented May 18, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 4b092d0 into asyncapi:master May 18, 2023
@smoya smoya deleted the chore/updateParsers branch May 18, 2023 11:12
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florence-Njeri Florence-Njeri Florence-Njeri approved these changes

@derberg derberg derberg approved these changes

@pratik9315 pratik9315 Awaiting requested review from pratik9315

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@fmvilas fmvilas Awaiting requested review from fmvilas

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate new ParserAPI
7 participants
@smoya @jonaslagoni @magicmatatjahu @fmvilas @derberg @asyncapi-bot @Florence-Njeri