Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use HTTP bindings correctly #579

Merged
merged 33 commits into from
Nov 23, 2023
Merged

fix: use HTTP bindings correctly #579

merged 33 commits into from
Nov 23, 2023

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Nov 15, 2023 •
edited
Loading

Description

  • Refactor HTTP client code for better maintainablility.
  • Refactor HTTP server code for better maintainablility.
  • Make sure both client and server use HTTP bindings to validate the requests.
  • Make sure the request/reply works with the HTTP protocol.

Related issue(s)
Resolves #553

KhudaDad414 and others added 21 commits October 20, 2023 17:41
@KhudaDad414
initial commit
044823a
@KhudaDad414
initial commit
62b7076
@KhudaDad414
Merge remote-tracking branch 'upstream/master' into v3-playground
2b40e2f
@KhudaDad414
initial draft
1ada3d4
@KhudaDad414
Merge branch 'v3-playground' into request-reply
839c82c
@KhudaDad414
use better names for channels and operations
8b97e96
@KhudaDad414
add readme
224391c
@KhudaDad414
update readme
a498823
@KhudaDad414
re-enable send
ac4c281
@KhudaDad414
Merge branch 'master' into request-reply
8c3f8f9
@KhudaDad414
Merge branch 'master' into request-reply
37c929e
@KhudaDad414
refactor
a7cca8b
@KhudaDad414
add tests
b214597
@KhudaDad414
remove warnings
8b3000c
@KhudaDad414 @fmvilas
Update src/adapters/http/client.ts
202176f 
Co-authored-by: Fran Méndez <[email protected]>
@KhudaDad414 @fmvilas
Update src/lib/adapter.ts
494d8a7 
Co-authored-by: Fran Méndez <[email protected]>
@KhudaDad414 @fmvilas
Update src/lib/functions.ts
73e2030 
Co-authored-by: Fran Méndez <[email protected]>
@KhudaDad414 @fmvilas
Update src/lib/functions.ts
02555cb 
Co-authored-by: Fran Méndez <[email protected]>
@KhudaDad414 @fmvilas
Update src/lib/functions.ts
8e5a1a1 
Co-authored-by: Fran Méndez <[email protected]>
@KhudaDad414
final touches
e585f17
@KhudaDad414
modify reply generation
9e99f90
@KhudaDad414 KhudaDad414 mentioned this pull request Nov 15, 2023
Closed
@KhudaDad414 KhudaDad414 marked this pull request as ready for review November 21, 2023 15:35
@KhudaDad414
Copy link
Member Author

@fmvilas @Souvikns please take a look when you have the time.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6946177953

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 69.331%
Files with Coverage Reduction New Missed Lines %
src/lib/util.ts 1 72.52%
Totals Coverage Status
Change from base Build 6945719552: -0.1%
Covered Lines: 368
Relevant Lines: 472
💛 - Coveralls

fmvilas
fmvilas approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as my only comment should not block this PR.

@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 5f5040f into asyncapi:master Nov 23, 2023
12 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use the correct bindings for http client
4 participants
@KhudaDad414 @coveralls @asyncapi-bot @fmvilas