feat: simplify done() function

[ankur0904]

Description

• This PR simplified the done() function to take only one input bool as input.
• The related documentation is also changed.

Related issue(s)
Resolves #596

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[KhudaDad414]

can you do the same for the WebSocket adapter?

[ankur0904]

@KhudaDad414 Sure :)

[KhudaDad414]

@ankur0904 do you need some help with this?

[ankur0904]

@KhudaDad414 The current code don't have code = 401, message = 'Unauthorized' these arguments where the changes is supposed to done.

Please tell me if I am missing something.

class HttpAdapter extends Adapter {
    ...
     // code of done function
      return {
        promise,
        done: (val: boolean) => {
          if (val) {
            resolveFunc(true)
          } else {
            rejectFunc({ code: 401, message: 'Unauthorized' })
          }
      }
   }
   ...
}

[KhudaDad414]

@ankur0904 ws adapter has the same code:

glee/src/adapters/ws/server.ts

Line 221 in 60484de

return function done(val: boolean, code = 401, message = 'Unauthorized') {

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[ankur0904]

Sorry, @KhudaDad414 I missed the ws folder. I made the commit in which the required changes are reflected. Please have a look.

[KhudaDad414]

@afzal442 this change will touch the docs. do you want to have look?

[coveralls]

Pull Request Test Coverage Report for Build 7265431969

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 72.884%

---

Totals
Change from base Build 7264150988:	0.0%
Covered Lines:	388
Relevant Lines:	483

---

💛 - Coveralls

[afzal442]

sure! I do. and thanks for reminder.

[afzal442]

So now done() func takes in boolean value only. LGTM!

[KhudaDad414]

LGTM!

[afzal442]

Thanks @ankur0904 for your contrib. 💪🏻

[afzal442]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[ankur0904]

Thanks @KhudaDad414 @afzal442 for merging the PR.