Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to parser API v3 #459

Merged
merged 8 commits into from
Nov 29, 2023
Merged

feat!: update to parser API v3 #459

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf4c6b5
bump versions
jonaslagoni Nov 15, 2023
115538a
update dependency
jonaslagoni Nov 16, 2023
2051172
update snapshots
jonaslagoni Nov 16, 2023
e4c1772
update test and dependency
jonaslagoni Nov 20, 2023
8d2bebc
remove unused argument
jonaslagoni Nov 20, 2023
edf0e34
Update helpers/all.js
derberg Nov 21, 2023
381796e
adapted test and dependencies
jonaslagoni Nov 29, 2023
673324d
Merge branch 'upstream_master' into bump_versions
jonaslagoni Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion helpers/all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ export function includeFile(pathFile) {
* and annotates that specification is parsed.
*/
export function stringifySpec(asyncapi) {
return stringify(asyncapi);
const stringifiedDoc = stringify(asyncapi);
if(stringifiedDoc === undefined) throw new Error("Unable to stringify parsed AsyncAPI document given by the generator, this should never happen... Please raise an issue for the html-template.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big cause of problems i.e. #456 (have had it multiple times). So thought it was better to throw an error instead of generating empty HTML pages.

derberg marked this conversation as resolved.
Show resolved Hide resolved
return stringifiedDoc
}

/**
Expand Down
Loading
Loading