Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use latest JavaScript Parser version #574

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

KhudaDad414
Copy link
Member

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Mar 25, 2024

package-lock also should be updated

also please have a look at failing tests. This is probably why parser was not updated as tests were failing, so I closed a automated PR

@derberg
Copy link
Member

derberg commented Mar 25, 2024

Also I think AsyncAPI CLI bump also fails for the same reason, some snapshot tests are modified with new version.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KhudaDad414
Copy link
Member Author

@derberg it should be good to go now. 👍

@derberg derberg changed the title feat: update parser-js version fix: use latest JavaScript Parser version Mar 26, 2024
@derberg
Copy link
Member

derberg commented Mar 26, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 285653a into asyncapi:master Mar 26, 2024
13 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants