Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: switch template from nunjucks to react rendering engine #267

Merged
merged 18 commits into from
Mar 22, 2024

Conversation

kaushik-rishi
Copy link
Collaborator

@kaushik-rishi kaushik-rishi commented Mar 18, 2024

Description

  • Switch the template from nunjucks to react rendering engine

Things to verify before merging

  • verify if scripts in package.json are running fine
  • update any/all snapshot tests
  • test the generated template for mqtt and mqtts
  • test kafka template snapshot tests
  • test by providing multiple channels for a single subscribe / publish
  • decide on new version to bump into (breaking change)

Related issue(s)
Issue #133

utils/channels-topics.js Outdated Show resolved Hide resolved
template/src/api/routes/$$channel$$.js Outdated Show resolved Hide resolved
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also make sure __transpiled is in .gitignore

@derberg derberg changed the title feat!: switch template from nunjucks to react rendering engine feat: switch template from nunjucks to react rendering engine Mar 22, 2024
@derberg derberg changed the title feat: switch template from nunjucks to react rendering engine feat!: switch template from nunjucks to react rendering engine Mar 22, 2024
derberg
derberg previously approved these changes Mar 22, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @kaushik-rishi

we need to do breaking change as 3658766 had to be done, to make sure generator with react engine is required. I also made sure to require minimum 1.15 that is the first version enabling v3 that you anyway need

2 followup changes are needed, in separate PR:

@derberg
Copy link
Member

derberg commented Mar 22, 2024

@kaushik-rishi sorry, had to update generator in dev dep

@kaushik-rishi
Copy link
Collaborator Author

great work @kaushik-rishi

we need to do breaking change as 3658766 had to be done, to make sure generator with react engine is required. I also made sure to require minimum 1.15 that is the first version enabling v3 that you anyway need

2 followup changes are needed, in separate PR:

Thanks for the review and generator version update.
Will do the required changes and push.

Copy link

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushik-rishi please do readme changes in separate

@derberg
Copy link
Member

derberg commented Mar 22, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 391dd6f into asyncapi:master Mar 22, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants