-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: switch template from nunjucks to react rendering engine #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also make sure __transpiled
is in .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @kaushik-rishi
we need to do breaking change as 3658766 had to be done, to make sure generator with react engine is required. I also made sure to require minimum 1.15 that is the first version enabling v3 that you anyway need
2 followup changes are needed, in separate PR:
template/README.md.js
has outdated instructions- https://github.com/asyncapi/nodejs-template/?tab=readme-ov-file#how-to-use-the-template is also outdated,
npm start
no longer makes sense. So combine some of the steps (but use AsyncAPI CLI) with https://github.com/asyncapi/nodejs-template/?tab=readme-ov-file#adding-custom-code--handlers that are fine - so it is end to end copy paste instruction - maybe it makes sense to have script from
Adding custom code / handlers
section actually stored intest
and have a script that starts it, likenpm run example
@kaushik-rishi sorry, had to update generator in dev dep |
Thanks for the review and generator version update. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaushik-rishi please do readme changes in separate
/rtm |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Things to verify before merging
package.json
are running fineRelated issue(s)
Issue #133