-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce the turborepo to the parser.js #1008
Conversation
@smoya added the @changelog/git and its working now . without installing the cli. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you properly tested the release on your own branch and npm account @ayushnau.
LGTM
/rtm |
For some reason, Sonarcloud status is not being reported. I see it is ok in https://sonarcloud.io/summary/new_code?id=asyncapi_parser-js&pullRequest=1008 Trying to push an empty commit so it triggers a new CI build. |
No success. BTW, I fixed the |
No, it's not. That instance ran 18 days ago 😮 Additionally, is pointing to a commit that I can't find within the commits of this branch ad50cc4 |
There was an issue with SonarCloud several weeks ago. It seems not to have a simple immediate solution. |
Yeah, I even tried to reset the config on Sonarcloud with no success. |
/rtm |
Found like it seems a workaround. See #1033 (comment) |
@smoya creating the pr for the multiparser. |
For the record, the release didn't work because the release action wasn't triggered when the automated PR was merged. The guess is that didn't work because of this https://github.com/asyncapi/parser-js/blob/master/.github/workflows/release-with-changesets.yml#L21-L26, however the PR was created as We would need to remove such checks as in https://github.com/asyncapi/studio/blob/master/.github/workflows/release.yml |
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes Added.
Related issue(s)
Related to: #963