-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated the method of importing the parser #1045
Conversation
🦋 Changeset detectedLatest commit: 5a237b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@smoya In your example the error is coming due to asyncapi validation other wise the multiparser package is working fine. I have used this package for testing. @ayushnautiyal706020/multi-parser |
@asyncapi/bounty_team |
I don't get why we need this change. Can you please elaborate on that? |
Attaching two screenshots running a simple example both with Using
|
Before I was using parserv3: file::../parser to import the parser in multiparser. but doing this way was creating problem in production build. of the multiparser. It turns out that in turborepo for importing internal dependency we need to use |
yes I am aware of this. Merging this pr will fix this. |
The prefix title of the pr should be fix. |
.changeset/bubble-beach.md
Outdated
"@asyncapi/multi-parser": patch | ||
--- | ||
|
||
Adding the Way the generator is imported in Nunjucks filter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve the message so it reflects what it fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Quality Gate passedIssues Measures |
/rtm |
/rtm |
1 similar comment
/rtm |
/rtm |
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes Added.
Related issue(s)
Related to: #963