refactor: add metadata to models #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
fmvilas,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
magicmatatjahu
requested review from
smoya
and removed request for
fmvilas,
derberg,
jonaslagoni and
asyncapi-bot-eve
|
@smoya Why do we need metadata and a pointer for example? E.g. in react component and also in studio we make anchors by which people can move between given sections of specification (in html preview and also in editor). Current solution in studio is custom and not very optimal. By adding this small thing to the model implementation we have the ability to specify where the object is located and it is version agnostic. In the future we can always add other things to the metadata that will be needed. Write what you think about it :) |
magicmatatjahu
force-pushed
the
next/model-metadata
branch
from
54355b8 to
bcb3d82
Compare
magicmatatjahu
force-pushed
the
next/model-metadata
branch
from
498f887 to
ba6f4f2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
magicmatatjahu
added a commit
to magicmatatjahu/parser-js
that referenced
this pull request
Oct 3, 2022
derberg
pushed a commit
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pointer(JSON Pointer),asyncapidata with detailed AsyncAPI document,parentwhich points to the parent modelRelated issue(s)
Part of #481
Part of #482