refactor: add Avro Schema Parser #576
Conversation
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
|
|
||
| async function parse(input: ParseSchemaInput<unknown, unknown>): Promise<AsyncAPISchema> { | ||
| const asyncAPISchema = await avroToJsonSchema(input.data as AvroSchema); | ||
| const message = (input.meta as any).message |
There was a problem hiding this comment.
The big change VS what we had previously is that the new interface passes directly the Schema in input.data rather than the message object.
I decided to add the message object in the input.meta and only in case it is there, do the modifications (if they are being done here finally).
There was a problem hiding this comment.
Ok, I will remember about that :) Avro parser there is a bit problematic 😅
|
I'm not involved in rewriting to TypeScript, so this might be silly question, but why are you porting avro schema parser here inside the parser? |
Even though there are unit tests, the idea is to have everything here, to do proper testing of the parser with those schema parsers, and once we confirm everything works as expected, to move the code to each schema parser repo. |
smoya
requested review from
magicmatatjahu
and removed request for
derberg,
jonaslagoni and
asyncapi-bot-eve
|
We can merge now as we have two approvals from code owners. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
Description
This PR does the following:
validate()method).Related issue(s)
#480