fix: set lockfile version to 2 fixing issues with @asyncapi/parser de… #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Oct 10, 2022
|
I can't see the diff here but going to totally trust you 😄 |
fmvilas
approved these changes
Oct 10, 2022
1
2.34
|
|
/rtm |
|
🎉 This PR is included in version 2.0.0-next-major.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lockfile version came back wrongly to v1 in 690cbea#r86313774
This caused some weird dependency issue and @asyncapi/parser seems not to be properly set at the right version (tested locally), creating the following error during Netlify build of this PR in Studio:
Source: https://app.netlify.com/sites/modest-rosalind-098b67/deploys/634022166f6f380008706b4c#L151
Something I don't get is why it is failing in Netlfiy but not in our CI 🤔
cc @magicmatatjahu @derberg