Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add reusable tags and externalDocs and move them to the info object #664

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Oct 27, 2022

Description

  • add tags() and externalDocs() methods to the Components models - update also v2 Components.
  • add Info, License, Contact, Components v3 models.
  • add ExternalDocumentations collection.
  • add unit tests.

cc @smoya

Related issue(s)
asyncapi/spec#792
asyncapi/spec#794

src/models/v2/contact.ts Outdated Show resolved Hide resolved
src/models/v3/contact.ts Outdated Show resolved Hide resolved
@magicmatatjahu
Copy link
Member Author

@jonaslagoni Done! Could you check again?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 6de1923 into asyncapi:next-major-spec Nov 8, 2022
@magicmatatjahu magicmatatjahu deleted the next-spec/tags-externalDocs branch November 8, 2022 13:41
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants