fix: isAsyncAPIDocument not recognizing correct documents #861
Conversation
jonaslagoni
requested review from
magicmatatjahu,
smoya and
asyncapi-bot-eve
as code owners
src/models/asyncapi.ts
Outdated
| @@ -12,7 +12,7 @@ import type { ServersInterface } from './servers'; | |||
| import type { v2, v3 } from '../spec-types'; | |||
|
|
|||
| // https://github.com/asyncapi/parser-api/releases/tag/v2.0.0 | |||
| export const ParserAPIVersion = '2.0.0'; | |||
| export const ParserAPIVersion = '2'; | |||
There was a problem hiding this comment.
Why changing this back to the major? Having that granularity of a full semver, we will always know which parser-api version was supported when parsing.
If you want to compare by major, you can ParserAPIVersion.split('.')[0], as in https://github.com/smoya/multi-parser-js/blob/main/src/utils.ts
There was a problem hiding this comment.
Thinking deeply, I'm not sure if has a useful use case. Even for debugging, knowing the version of the Parser-JS is more than enough.
If you don't see one use case either (as I guess), we should also change the multi-parser-js library (I'm more than happy to accept a PR)
There was a problem hiding this comment.
I dont imidiately see a reason to have the full number there, also that would mean we would need to change it for each change we do, not really maintainable 🤔
There was a problem hiding this comment.
The multi parser implementation would still work right?
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 3.0.0-next-major-spec.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR fixes a problem where
isAsyncAPIDocumentcannot recognize parsed documents which means a lot of support functions are not working correctly.