Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing stoplight dependencies #882

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: add missing stoplight dependencies #882

merged 2 commits into from
Oct 20, 2023

Conversation

woylie
Copy link
Contributor

@woylie woylie commented Oct 16, 2023

Description

This adds four stoplight dependencies that were missing, which caused Yarn 2/3 in pnp mode to return an error. I hope this is all that had to be done and doesn't cause any issues.

Related issue(s)
Resolves #733

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@woylie woylie marked this pull request as ready for review October 16, 2023 14:36
package-lock.json Outdated Show resolved Hide resolved
@smoya
Copy link
Member

smoya commented Oct 16, 2023

@woylie npm run install command is failing with:

npm verb stack @stoplight/json-ref-readers: No matching version found for @stoplight/[email protected].
npm verb stack     at module.exports (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/npm-pick-manifest/lib/index.js:209:23)
npm verb stack     at RegistryFetcher.manifest (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/pacote/lib/registry.js:125:22)
npm verb stack     at async Arborist.[nodeFromEdge] (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:1061:19)
npm verb stack     at async Arborist.[buildDepStep] (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:930:11)
npm verb stack     at async Arborist.buildIdealTree (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:211:7)
npm verb stack     at async Promise.all (index 1)
npm verb stack     at async Arborist.reify (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:1[54](https://github.com/asyncapi/parser-js/actions/runs/6535668041/job/17758980054?pr=882#step:8:55):5)
npm verb stack     at async Install.exec (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/lib/commands/install.js:145:5)
npm verb stack     at async module.exports (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/lib/cli.js:78:5)
npm verb cwd /home/runner/work/parser-js/parser-js
npm verb Linux 6.2.0-1012-azure
npm verb node v16.20.2
npm verb npm  v8.19.4
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @stoplight/[email protected].
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

See https://github.com/asyncapi/parser-js/actions/runs/6535668041/job/17758980054?pr=882#step:8:49

@woylie
Copy link
Contributor Author

woylie commented Oct 16, 2023

@woylie npm run install command is failing with:

npm verb stack @stoplight/json-ref-readers: No matching version found for @stoplight/[email protected].
npm verb stack     at module.exports (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/npm-pick-manifest/lib/index.js:209:23)
npm verb stack     at RegistryFetcher.manifest (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/pacote/lib/registry.js:125:22)
npm verb stack     at async Arborist.[nodeFromEdge] (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:1061:19)
npm verb stack     at async Arborist.[buildDepStep] (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:930:11)
npm verb stack     at async Arborist.buildIdealTree (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:211:7)
npm verb stack     at async Promise.all (index 1)
npm verb stack     at async Arborist.reify (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:1[54](https://github.com/asyncapi/parser-js/actions/runs/6535668041/job/17758980054?pr=882#step:8:55):5)
npm verb stack     at async Install.exec (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/lib/commands/install.js:145:5)
npm verb stack     at async module.exports (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/npm/lib/cli.js:78:5)
npm verb cwd /home/runner/work/parser-js/parser-js
npm verb Linux 6.2.0-1012-azure
npm verb node v16.20.2
npm verb npm  v8.19.4
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @stoplight/[email protected].
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

See https://github.com/asyncapi/parser-js/actions/runs/6535668041/job/17758980054?pr=882#step:8:49

I shouldn't stay up so late.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@smoya
Copy link
Member

smoya commented Oct 18, 2023

@magicmatatjahu would you like to take a look just in case? I gave my +1

@jonaslagoni
Copy link
Member

Dont see a reason to wait, its not like it will break anything 🙂

/rtm

@asyncapi-bot asyncapi-bot merged commit 151ac62 into asyncapi:master Oct 20, 2023
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undeclared dependencies error under Yarn PnP
4 participants