-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing stoplight dependencies #882
fix: add missing stoplight dependencies #882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@woylie
See https://github.com/asyncapi/parser-js/actions/runs/6535668041/job/17758980054?pr=882#step:8:49 |
I shouldn't stay up so late. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
@magicmatatjahu would you like to take a look just in case? I gave my +1 |
Dont see a reason to wait, its not like it will break anything 🙂 /rtm |
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0-next-major-spec.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This adds four stoplight dependencies that were missing, which caused Yarn 2/3 in pnp mode to return an error. I hope this is all that had to be done and doesn't cause any issues.
Related issue(s)
Resolves #733