fix: change ParserAPIVersion constant to 3 #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
Good catch, thanks! So, since you're here already, would you mind also changing this table? https://github.com/asyncapi/parser-js/blob/master/README.md#api-documentation |
Done! 🚀 |
smoya
commented
Nov 7, 2023
fmvilas
reviewed
Nov 7, 2023
README.md
Outdated
Comment on lines
26
to
33
| * [Example with parsing](#example-with-parsing) | ||
| * [Example with validation](#example-with-validation) | ||
| * [Example using Avro schemas](#example-using-avro-schemas) | ||
| * [Example using OpenAPI schemas](#example-using-openapi-schemas) | ||
| * [Example using RAML data types](#example-using-raml-data-types) | ||
| * [Example with performing actions on HTTP source](#example-with-performing-actions-on-http-source) | ||
| * [Example with performing actions on file source](#example-with-performing-actions-on-file-source) | ||
| * [Example with stringify and unstringify parsed document](#example-with-stringify-and-unstringify-parsed-document) | ||
| - [Example with parsing](#example-with-parsing) | ||
| - [Example with validation](#example-with-validation) | ||
| - [Example using Avro schemas](#example-using-avro-schemas) | ||
| - [Example using OpenAPI schemas](#example-using-openapi-schemas) | ||
| - [Example using RAML data types](#example-using-raml-data-types) | ||
| - [Example with performing actions on HTTP source](#example-with-performing-actions-on-http-source) | ||
| - [Example with performing actions on file source](#example-with-performing-actions-on-file-source) | ||
| - [Example with stringify and unstringify parsed document](#example-with-stringify-and-unstringify-parsed-document) |
There was a problem hiding this comment.
Someone has a prettifier installed 😄
fmvilas
previously approved these changes
Nov 7, 2023
smoya
force-pushed
the
fix/parserAPIVersion
branch
from
f5d2116 to
1d15cb4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
fmvilas
approved these changes
Nov 7, 2023
|
/rtm |
|
🎉 This PR is included in version 3.0.0-next-major-spec.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After recent changes made in #889, this latest version of the Parser only supports Parser-API v3 instead of v2.
This PR fixes that.
Related issue(s)
#889