Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: merge next-major into master #15

Merged
merged 1 commit into from
Apr 25, 2023
Merged

feat!: merge next-major into master #15

merged 1 commit into from
Apr 25, 2023

Conversation

GreenRover
Copy link
Collaborator

Description

This PR merges next-major branch into master.

Warning
DO NOT SQUASH. USE REBASE OR MERGE

next-major branch includes the rewrite to TypeScript and adapts to the new Parser-API interface.
It is BC (see commits included with feat!: prefix).

Related issue(s)
asyncapi/parser-js#481

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GreenRover
Copy link
Collaborator Author

@derberg or @fmvilas can you please review build and publishing. I am not sure if i get all essential parts of application.json

@derberg
Copy link
Member

derberg commented Apr 18, 2023

actually the best for review would be @smoya

also, @smoya can you please have a look at #20

please add this protobuf template to https://github.com/asyncapi/parser-js/blob/master/.github/workflows/bump.yml#L35 once this PR is merged. So only RC updates will come from bot from JS Parser. Now bot will bomb this project with automated bumps from any release, main or RC

@GreenRover GreenRover requested review from smoya and removed request for fmvilas and derberg April 24, 2023 09:53
@smoya
Copy link
Member

smoya commented Apr 24, 2023

also, @smoya can you please have a look at #20

Added a comment about why that PR is failing.

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@derberg
Copy link
Member

derberg commented Apr 24, 2023

@GreenRover before you get approval from @nathanaelweber and merge, remember about adjusting PR title prefix to feat!: as you need to release this one as 2.0

@GreenRover GreenRover changed the title chore: merge next-major into master feat!: merge next-major into master Apr 25, 2023
@GreenRover
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit d9c26c1 into master Apr 25, 2023
1 check passed
@asyncapi-bot asyncapi-bot deleted the next-major branch April 25, 2023 10:01
@smoya
Copy link
Member

smoya commented Apr 25, 2023

@GreenRover before you get approval from @nathanaelweber and merge, remember about adjusting PR title prefix to feat!: as you need to release this one as 2.0

Too late, but two things to say here:

  1. That was totally not needed if the merge is done without the /rtm as @GreenRover suggested. In this case, not really needed since there was only one commit and the author is still @GreenRover.
  2. The commit message now it's not correct: [feat!: merge next-major into master](https://github.com/asyncapi/protobuf-schema-parser/pull/15#top) VS feat!: implement new Parser-js interface. but now is merged, and released with that title as breaking change 😅

@derberg
Copy link
Member

derberg commented May 11, 2023

actually I do not see 2.0 was released

@GreenRover GreenRover restored the next-major branch September 5, 2023 12:37
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants