Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for comments and annotations #66

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat: add support for comments and annotations #66

merged 1 commit into from
Jan 30, 2024

Conversation

GreenRover
Copy link
Collaborator

Description

  • Add support for comments
  • Add support for validation annotations in field comments
  • Add support for @example annotation in field comments
  • Add support for @default annotation in field comments
  • Add support for @rootnode annotation in message comments, to give hint for root nodes

@GreenRover
Copy link
Collaborator Author

/rtm

@GreenRover GreenRover self-assigned this Jan 29, 2024
@GreenRover GreenRover force-pushed the feature/support_comments branch from eac6386 to f645c4b Compare January 29, 2024 21:03
@GreenRover GreenRover force-pushed the feature/support_comments branch 2 times, most recently from 9347cd0 to 35cfaac Compare January 29, 2024 21:11
@GreenRover GreenRover changed the title Add support for comments and annotations feat: Add support for comments and annotations Jan 29, 2024
@GreenRover GreenRover changed the title feat: Add support for comments and annotations feat: add support for comments and annotations Jan 29, 2024
@GreenRover
Copy link
Collaborator Author

/rtm

@GreenRover GreenRover force-pushed the feature/support_comments branch from 35cfaac to 042d6be Compare January 29, 2024 21:22
@GreenRover
Copy link
Collaborator Author

/rtm

nathanaelweber
nathanaelweber previously approved these changes Jan 30, 2024
View reviewed changes
@GreenRover GreenRover force-pushed the feature/support_comments branch from 042d6be to e4338ed Compare January 30, 2024 09:41
@GreenRover GreenRover force-pushed the feature/support_comments branch from e4338ed to 8b7a5d2 Compare January 30, 2024 09:41
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GreenRover
Copy link
Collaborator Author

/rtm

@GreenRover GreenRover merged commit e554fed into master Jan 30, 2024
11 checks passed
@GreenRover GreenRover deleted the feature/support_comments branch January 30, 2024 11:44
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanaelweber nathanaelweber nathanaelweber approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

@GreenRover GreenRover

Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GreenRover @asyncapi-bot @nathanaelweber