Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Resolve different code issues in template filter #29

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

depimomo
Copy link
Contributor

@depimomo depimomo commented Oct 6, 2020

Description
Fix some SonarCube issues such as unnecessary variable and declaring const in for loop

Related issue(s)
Fixes #24

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@depimomo
Copy link
Contributor Author

depimomo commented Oct 6, 2020

I want to ask, may I remove some of the console log comments to make the code cleaner?

@derberg
Copy link
Member

derberg commented Oct 7, 2020

@depimomo great that you asked first. This template is in the early stage of development and @damaru-inc left those to make it much easier in development to console log typical cases. We need a mechanism in the generator (the tool that processes the template) to pass a debug flag to templates hooks/filters so we can have logs there by default, so you can just enable them with --debug. Luckly we have an issue for that case asyncapi/generator#369

Anyway, thanks a lot for your contribution!

@derberg derberg changed the title fix: fix some issues in template filter refactor: Resolve different code issues in template filter Oct 7, 2020
@derberg derberg merged commit b82e9df into asyncapi:master Oct 7, 2020
@depimomo
Copy link
Contributor Author

depimomo commented Oct 7, 2020

Thank you for all the lesson across my PRs in several repo, I notice that I make mistake for the title. From now I will use the prefix appropriately (fix, test, refactor, etc).

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.2.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform some fixes in template filters
3 participants