Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove messageId from Message and MessageTrait objects #439

Merged

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Nov 3, 2023

Description

Removes the messageId property from the Message and MessageTrait objects.

Related issue(s)
asyncapi/spec#978

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@fmvilas
Copy link
Member Author

fmvilas commented Nov 6, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c097eb5 into asyncapi:next-major-spec Nov 6, 2023
20 checks passed
@fmvilas fmvilas deleted the remove-message-id-from-v3 branch November 6, 2023 12:06
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants