-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: added code linting #473
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
34f087b
added code linting
Gmin2 c3e7dbd
added eslintignore
Gmin2 da9d4ce
fix a typo
Gmin2 6fbc667
a small change
Gmin2 57c78e7
resolves the failing test
Gmin2 0f2bc17
remove all lintng errors
Gmin2 2fe5ccf
lol
Gmin2 a996eef
fixed sonarcloud error
Gmin2 85a867f
cleanup
Gmin2 12bcdeb
added the reviewed changes
Gmin2 680a98c
spdated with default parser and remove optional chaining
Gmin2 2a57d2b
remove some conflict and remove nested ternary operator
Gmin2 dc6b823
Merge branch 'master' into lint
Gmin2 ce28b57
cleanup
Gmin2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,112 @@ | ||||||||
parser: "@babel/eslint-parser" | ||||||||
|
||||||||
env: | ||||||||
node: true | ||||||||
es6: true | ||||||||
mocha: true | ||||||||
browser: true | ||||||||
|
||||||||
plugins: | ||||||||
- sonarjs | ||||||||
|
||||||||
extends: | ||||||||
- eslint:recommended | ||||||||
- plugin:sonarjs/recommended | ||||||||
|
||||||||
parserOptions: | ||||||||
requireConfigFile: false | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed to make it work with async
Suggested change
|
||||||||
|
||||||||
rules: | ||||||||
# Ignore Rules | ||||||||
strict: 0 | ||||||||
no-underscore-dangle: 0 | ||||||||
no-mixed-requires: 0 | ||||||||
no-process-exit: 0 | ||||||||
no-warning-comments: 0 | ||||||||
no-use-before-define: 0 | ||||||||
curly: 0 | ||||||||
no-multi-spaces: 0 | ||||||||
no-alert: 0 | ||||||||
consistent-return: 0 | ||||||||
consistent-this: [0, self] | ||||||||
func-style: 0 | ||||||||
max-nested-callbacks: 0 | ||||||||
camelcase: 0 | ||||||||
no-dupe-class-members: 0 | ||||||||
security/detect-object-injection: 0 | ||||||||
sonarjs/no-small-switch: 0 | ||||||||
sonarjs/no-nested-template-literals: 0 | ||||||||
|
||||||||
# Warnings | ||||||||
no-debugger: 1 | ||||||||
no-empty: 1 | ||||||||
no-invalid-regexp: 1 | ||||||||
no-unused-expressions: 1 | ||||||||
no-native-reassign: 1 | ||||||||
no-fallthrough: 1 | ||||||||
sonarjs/cognitive-complexity: 1 | ||||||||
|
||||||||
# Errors | ||||||||
eqeqeq: 2 | ||||||||
no-undef: 2 | ||||||||
no-dupe-keys: 2 | ||||||||
no-empty-character-class: 2 | ||||||||
no-self-compare: 2 | ||||||||
valid-typeof: 2 | ||||||||
handle-callback-err: 2 | ||||||||
no-shadow-restricted-names: 2 | ||||||||
no-new-require: 2 | ||||||||
no-mixed-spaces-and-tabs: 2 | ||||||||
block-scoped-var: 2 | ||||||||
no-else-return: 2 | ||||||||
no-throw-literal: 2 | ||||||||
no-void: 2 | ||||||||
radix: 2 | ||||||||
wrap-iife: [2, outside] | ||||||||
no-shadow: 0 | ||||||||
no-path-concat: 2 | ||||||||
valid-jsdoc: [0, {requireReturn: false, requireParamDescription: false, requireReturnDescription: false}] | ||||||||
|
||||||||
# stylistic errors | ||||||||
no-spaced-func: 2 | ||||||||
semi-spacing: 2 | ||||||||
quotes: [2, 'single'] | ||||||||
key-spacing: [2, { beforeColon: false, afterColon: true }] | ||||||||
indent: [2, 2] | ||||||||
no-lonely-if: 2 | ||||||||
no-floating-decimal: 2 | ||||||||
brace-style: [2, 1tbs, { allowSingleLine: true }] | ||||||||
comma-style: [2, last] | ||||||||
no-multiple-empty-lines: [2, {max: 1}] | ||||||||
no-nested-ternary: 2 | ||||||||
operator-assignment: [2, always] | ||||||||
padded-blocks: [2, never] | ||||||||
quote-props: [2, as-needed] | ||||||||
keyword-spacing: [2, {'before': true, 'after': true, 'overrides': {}}] | ||||||||
space-before-blocks: [2, always] | ||||||||
array-bracket-spacing: [2, never] | ||||||||
computed-property-spacing: [2, never] | ||||||||
space-in-parens: [2, never] | ||||||||
space-unary-ops: [2, {words: true, nonwords: false}] | ||||||||
wrap-regex: 2 | ||||||||
linebreak-style: 0 | ||||||||
semi: [2, always] | ||||||||
arrow-spacing: [2, {before: true, after: true}] | ||||||||
no-class-assign: 2 | ||||||||
no-const-assign: 2 | ||||||||
no-this-before-super: 2 | ||||||||
no-var: 2 | ||||||||
object-shorthand: [2, always] | ||||||||
prefer-arrow-callback: 2 | ||||||||
prefer-const: 2 | ||||||||
prefer-spread: 2 | ||||||||
prefer-template: 2 | ||||||||
|
||||||||
overrides: | ||||||||
- files: | ||||||||
- "test/**" | ||||||||
rules: | ||||||||
prefer-arrow-callback: 0 | ||||||||
sonarjs/no-duplicate-string: 0 | ||||||||
security/detect-object-injection: 0 | ||||||||
security/detect-non-literal-fs-filename: 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,22 @@ | ||
module.exports = { | ||
'schemas': { | ||
'2.0.0': require('./schemas/2.0.0.json'), | ||
'2.1.0': require('./schemas/2.1.0.json'), | ||
'2.2.0': require('./schemas/2.2.0.json'), | ||
'2.3.0': require('./schemas/2.3.0.json'), | ||
'2.4.0': require('./schemas/2.4.0.json'), | ||
'2.5.0': require('./schemas/2.5.0.json'), | ||
'2.6.0': require('./schemas/2.6.0.json'), | ||
'3.0.0': require('./schemas/3.0.0.json'), | ||
}, | ||
'schemasWithoutId': { | ||
'2.0.0': require('./schemas/2.0.0-without-$id.json'), | ||
'2.1.0': require('./schemas/2.1.0-without-$id.json'), | ||
'2.2.0': require('./schemas/2.2.0-without-$id.json'), | ||
'2.3.0': require('./schemas/2.3.0-without-$id.json'), | ||
'2.4.0': require('./schemas/2.4.0-without-$id.json'), | ||
'2.5.0': require('./schemas/2.5.0-without-$id.json'), | ||
'2.6.0': require('./schemas/2.6.0-without-$id.json'), | ||
'3.0.0': require('./schemas/3.0.0-without-$id.json'), | ||
} | ||
schemas: { | ||
'2.0.0': require('./schemas/2.0.0.json'), | ||
'2.1.0': require('./schemas/2.1.0.json'), | ||
'2.2.0': require('./schemas/2.2.0.json'), | ||
'2.3.0': require('./schemas/2.3.0.json'), | ||
'2.4.0': require('./schemas/2.4.0.json'), | ||
'2.5.0': require('./schemas/2.5.0.json'), | ||
'2.6.0': require('./schemas/2.6.0.json'), | ||
'3.0.0': require('./schemas/3.0.0.json'), | ||
}, | ||
schemasWithoutId: { | ||
'2.0.0': require('./schemas/2.0.0-without-$id.json'), | ||
'2.1.0': require('./schemas/2.1.0-without-$id.json'), | ||
'2.2.0': require('./schemas/2.2.0-without-$id.json'), | ||
'2.3.0': require('./schemas/2.3.0-without-$id.json'), | ||
'2.4.0': require('./schemas/2.4.0-without-$id.json'), | ||
'2.5.0': require('./schemas/2.5.0-without-$id.json'), | ||
'2.6.0': require('./schemas/2.6.0-without-$id.json'), | ||
'3.0.0': require('./schemas/3.0.0-without-$id.json'), | ||
} | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why babel? Why do we need even changing the default parser? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i run
npm run lint
it gives the same errorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those errors seem genuine to me, and are errors we should fix in our code.
That screenshot about babel has nothing to do with this as far as I can see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoya i have reffered this and have used
babel-eslint
I might be wrong here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That example uses React, which iirc uses Babel.
Thats the reason they are talking about babel.
We do not need any parser different than the default one.