Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kafka bindings not using latest version #501

Merged

Conversation

dalelane
Copy link
Collaborator

cf. spotted in a comment in
#481

@dalelane
Copy link
Collaborator Author

/au

cf. spotted in a comment in
asyncapi#481

Signed-off-by: Dale Lane <[email protected]>
@dalelane dalelane force-pushed the add-missing-kafka-binding-version branch from 724f409 to ffbd4d1 Compare March 14, 2024 10:18
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@derberg
Copy link
Member

derberg commented Mar 14, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 59613c8 into asyncapi:master Mar 14, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ctasada
Copy link
Contributor

ctasada commented Mar 31, 2024

@dalelane could it be that the 0.5.0 version is missing at https://github.com/asyncapi/spec-json-schemas/blame/bee34d8569a18ee2117b4f2b0529a4e883e73638/definitions/3.0.0/serverBindingsObject.json#L53 too?

We're trying to upgrade Springwolf-asyncapi to support Kafka 0.5.0 bindings, but the cli parser complains with an error about unsupported version.

@jonaslagoni
Copy link
Member

@ctasada yep, mind opening a PR?

ctasada pushed a commit to ctasada/spec-json-schemas that referenced this pull request Mar 31, 2024
@ctasada
Copy link
Contributor

ctasada commented Mar 31, 2024

@jonaslagoni I created #508

Looking forward for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants