feat: extend aws policy configuration #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Pakisan
requested changes
Jun 26, 2024
Pakisan
requested changes
Jun 27, 2024
|
@Gadam8 looks good Don't forget to update information about SNS and SQS here: |
VisualBean
reviewed
Jul 1, 2024
|
Maybe make it an enum for one of them 😅.
Whatever makes the most sense and is the most ‘true’ to the spec i guess.
|
VisualBean
approved these changes
Jul 17, 2024
I've raised a PR to address this here asyncapi/bindings#256 |
Pakisan
approved these changes
Jul 24, 2024
|
@iancooper @dpwdec up! |
dpwdec
approved these changes
Aug 14, 2024
|
✅ |
|
@iancooper hi! One more day, and I'll merge fyi: @Gadam8 @dpwdec @VisualBean |
iancooper
approved these changes
Aug 14, 2024
VisualBean
approved these changes
Aug 15, 2024
|
🎉 This PR is included in version 6.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current AWS policy binding configuration doesn't match what is offered by AWS when configuring IAM policies.
ConditionandResourceare missing andPrincipalisn't fully fleshed out. This PR addresses this by extending the binding configuration for SNS and SQS.Related issue(s)