feat: added tooltips for navigation bar (#193) #215
Conversation
|
✔️ Deploy Preview for modest-rosalind-098b67 ready! 🔨 Explore the source changes: abab3c0 🔍 Inspect the deploy log: https://app.netlify.com/sites/modest-rosalind-098b67/deploys/61bb1808fc8012000753160a 😎 Browse the preview: https://deploy-preview-215--modest-rosalind-098b67.netlify.app/ |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -116,6 +117,7 @@ export const Sidebar: React.FunctionComponent<SidebarProps> = () => { | |||
| <div className="flex flex-col"> | |||
| <SettingsModal /> | |||
| </div> | |||
| <ReactTooltip effect='solid' backgroundColor='#374151' arrowColor='#374151' className="text-xs" /> | |||
There was a problem hiding this comment.
So if I wanna add tooltip in another part of Studio, e.g. in Editor, then I should copy that component and use data-tip attributes? 🤔 I think that component that wraps given component and add tooltip will be better, something like:
<Tooltip content={...}>
//...some component
</Tooltip>is there any another tooltip component in the OpenSource?
|
Thanks @boyney123 for adding this!! 🎉 However, I think if we made the background of the labels fully opaque it would look a lot cleaner. I think it might be a little distracting to see things peeking through behind the labels as the text size is already rather small. What do you think?
I agree with @magicmatatjahu here completely!! Better accessibility 😎 |
|
Hey guys! Was cleaning out my inbox and realized that this PR has yet to be merged. I think this is still a great feature that we should consider revisiting and merging. I think all we should do is make the tool tips fully opaque instead of transparent and integrate them with the entire button and not just the icon. Then we should definitely ship it! What do you guys think? |
|
@mcturco Yeah, we should handle that PR as you wrote. If @boyney123 you don't have time I can handle that, no problem :) |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
Tooltips added in the #434 PR @boyney123 I hope that you don't have a problem that I'm closing this PR :) |
Description
Following #193, I added some tooltips to the navigation bar.
Let me know what you think @mcturco @magicmatatjahu