Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling i18n feature for smaller screens #2708

Open
2 tasks done
sambhavgupta0705 opened this issue Feb 27, 2024 · 29 comments · May be fixed by #3113
Open
2 tasks done

Enabling i18n feature for smaller screens #2708

sambhavgupta0705 opened this issue Feb 27, 2024 · 29 comments · May be fixed by #3113
Labels
area/design Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement stale

Comments

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Feb 27, 2024

Why do we need this improvement?

Currently we have i18n feature for large screens but not for smaller screens.
So we should work on enabling it for smaller screen
For which first we need a design and need to know where can we place the button to switch to different languages

How will this change help?

It will enable translation to various language for smaller screens

Screenshots

No response

How could it be implemented/designed?

A design can be proposed by @Mayaleeeee on which we can work

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

No, someone else can work on it.

@sambhavgupta0705
Copy link
Member Author

This is not a good first issue and for this first we need a design to be implemented
cc: @anshgoyalevil

@sambhavgupta0705 sambhavgupta0705 added the area/design Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. label Feb 27, 2024
@Aryann15
Copy link

Aryann15 commented Feb 28, 2024

Hey @sambhavgupta0705!, would like to work on this (ofc, after the design is finalized), Can i get it assigned ?
Thanks!

@AbhishekCS3459
Copy link
Contributor

AbhishekCS3459 commented Feb 28, 2024

@sambhavgupta0705 can I go for this i18 button Design in mobile devices?
WhatsApp Image 2024-02-28 at 14 41 41_0906dbfc

@anshgoyalevil
Copy link
Member

@Aryann15 @AbhishekCS3459 Guys you need to wait until we get a design spec for this button from @Mayaleeeee

@its-kunal
Copy link
Contributor

Hey @Mayaleeeee, can please design the spec for I18N button

@Mayaleeeee
Copy link
Member

Hey @Mayaleeeee, can please design the spec for I18N button

I'll take a look at it.

@its-kunal
Copy link
Contributor

Hey @Mayaleeeee, any update related to this

@akkshitgupta
Copy link
Contributor

We can go for this particular icon, available in hero icons, as it's always preferred to use icons on small screens, unless the icon is very underrated and doesn't convey it's purpose.

not sure if this is a great suggestion
image

@AbhishekCS3459
Copy link
Contributor

@akkshitgupta Can I go for it as I was working on it earlier?

@akkshitgupta
Copy link
Contributor

@AbhishekCS3459 you can go for it once @Mayaleeeee confirms what should be done. it is still under discussion i guess ;)

@Mayaleeeee
Copy link
Member

We can go for this particular icon, available in hero icons, as it's always preferred to use icons on small screens, unless the icon is very underrated and doesn't convey it's purpose.

not sure if this is a great suggestion
image

Do you mean the language icon?

@akkshitgupta
Copy link
Contributor

Yes @Mayaleeeee, the language icon. may be the green mark is creating confusion. that mark was on the website

@Mayaleeeee
Copy link
Member

Yes @Mayaleeeee, the language icon. may be the green mark is creating confusion. that mark was on the website

which green mark? I don't understand

@akkshitgupta
Copy link
Contributor

I misunderstood your question here, my bad 😅

Do you mean the language icon?

@sambhavgupta0705
Copy link
Member Author

@akkshitgupta you can make a design for the smaller screen which we can later review for smooth working

@AbhishekCS3459
Copy link
Contributor

@sambhavgupta0705 can I proceed?

@sambhavgupta0705
Copy link
Member Author

Ohh my bad
@akkshitgupta as @AbhishekCS3459 was the first one to show interest in working on this so his PR for this issue would be considered first

@AbhishekCS3459
Copy link
Contributor

AbhishekCS3459 commented Mar 22, 2024

@akkshitgupta so can I proceed?

@sambhavgupta0705
Copy link
Member Author

@AbhishekCS3459 yes you may

@AbhishekCS3459
Copy link
Contributor

Hey @sambhavgupta0705, could you please explain the flow? When the user clicks the new icon above, does it trigger a dropdown with various icons, similar to the existing setup?

@sambhavgupta0705
Copy link
Member Author

similar to the existing setup?

yeahhh

@sambhavgupta0705
Copy link
Member Author

any update @AbhishekCS3459 ?

@AbhishekCS3459
Copy link
Contributor

@sambhavgupta0705, I am coming up with a PR today.

@sambhavgupta0705
Copy link
Member Author

okay!!

@sambhavgupta0705
Copy link
Member Author

@AbhishekCS3459 what's the status of the PR?

@TenzDelek
Copy link
Contributor

@sambhavgupta0705 can i work on it?

@TenzDelek
Copy link
Contributor

@sambhavgupta0705 hello, if the previous developer is still working on it, you can close this pr

@sambhavgupta0705
Copy link
Member Author

sambhavgupta0705 commented Apr 18, 2024

@TenzDelek the previous contributor hasn't raised any PR from the past 2 weeks so this issue has been shifted to you so your PR will be considered for this issue

@TenzDelek TenzDelek linked a pull request Jul 24, 2024 that will close this issue
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/design Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement stale
Projects
None yet
8 participants