-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update test script in package.json #2699
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2699--asyncapi-website.netlify.app/ |
.github/workflows/lint-pr.yml
Outdated
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint checks don't differ according to the OS. So, we don't need different OS here.
.github/workflows/lint-pr.yml
Outdated
- name: Set git to use LF #to once and for all finish neverending fight between Unix and Windows | ||
run: | | ||
git config --global core.autocrlf false | ||
git config --global core.eol lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid this step as we only need to run this workflow in ubuntu.
instead of adding custom workflow, I suggest we pick https://github.com/asyncapi/.github/blob/master/.github/workflows/if-nodejs-pr-testing.yml and always use the generic one. It is battle tested and has nice Yes, I know we already have workflow for cypress and we have I always recommend to have as minimum number of custom scripts as possible |
Currently, we don't want to update in any workflows in master branch. Hence, I thought of creating this workflow only for If we add asyncapi/.github@master/.github/workflows/if-nodejs-pr-testing.ym directly to |
@Shurtu-gal Please avoid making new branch from master, if we are merging the changes in |
@derberg I had suggested the same, as we are currently trying to improve the CI/CD. If changing |
@Shurtu-gal We can't, the PR is intended to be for |
It is meant to be in master. |
/rtm |
Description
Changed the test script in
package.json
to not run the tests in thenodejs
test workflow.