Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alignment of case study card in the case-studies page is fixed #2726

Closed
wants to merge 1 commit into from

Conversation

krshishir1
Copy link

Fixes #2725

Description

  • CaseStudyCard.js file is modified to address this issue.
  • The webpage looks good and responsive in both mobile and desktop application.

case-study-card-fix

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e3e15d1
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65e49cccaee76f0008d3c58e
😎 Deploy Preview https://deploy-preview-2726--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2726--asyncapi-website.netlify.app/

@vishvamsinh28
Copy link
Contributor

Yo @krshishir1, this was on purpose because we didn't need case study cards in the center 😅

Am I right? @derberg

@krshishir1
Copy link
Author

Yo @krshishir1, this was on purpose because we didn't need case study cards in the center 😅

I didn't know that was on purpose. Let's confirm from @derberg then.

@sambhavgupta0705
Copy link
Member

@krshishir1 that was on purpose as @vishvamsinh28 said.
In future we will be adding more casetsudies to the website .
Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment of the Case study card in larger screens.
4 participants