Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added index.md file to /extensions to fix unexpected 404 #2901

Merged

Conversation

SGI-CAPP-AT2
Copy link
Contributor

Description

Result
image

Related issue(s)
Fixes #2890

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 31cd9de
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/663d456a17488900088b115e
😎 Deploy Preview https://deploy-preview-2901--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Apr 24, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2901--asyncapi-website.netlify.app/

@SGI-CAPP-AT2 SGI-CAPP-AT2 changed the title Fixes #2890 : Added index.md file to /extensions Fix : added index.md file to /extensions to fix unexpected 404 Apr 24, 2024
@SGI-CAPP-AT2 SGI-CAPP-AT2 changed the title Fix : added index.md file to /extensions to fix unexpected 404 fix : added index.md file to /extensions to fix unexpected 404 Apr 24, 2024
@SGI-CAPP-AT2 SGI-CAPP-AT2 changed the title fix : added index.md file to /extensions to fix unexpected 404 fix: added index.md file to /extensions to fix unexpected 404 Apr 24, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for such quick PR. Left some comments

pages/docs/reference/extensions/x.md Outdated Show resolved Hide resolved
pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
@SGI-CAPP-AT2
Copy link
Contributor Author

@derberg committed new changes

@SGI-CAPP-AT2 SGI-CAPP-AT2 requested a review from derberg April 24, 2024 11:36
@sambhavgupta0705
Copy link
Member

/update

derberg
derberg previously approved these changes Apr 25, 2024
@derberg
Copy link
Member

derberg commented Apr 25, 2024

@alequetzalli please review

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick PR resolving the issue @SGI-CAPP-AT2

LGTM! ✅

cc @alequetzalli

pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
pages/docs/reference/extensions/index.md Outdated Show resolved Hide resolved
@asyncapi-bot asyncapi-bot requested a review from TRohit20 May 9, 2024 21:51
@quetzalliwrites quetzalliwrites merged commit 8b58b33 into asyncapi:master May 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions are redirecting to 404 page
6 participants