chore: update meetings.json and newsrooom_videos.json #3341
Conversation
asyncapi-bot
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe changes involve updates to two JSON configuration files: Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- config/newsroom_videos.json (1 hunks)
- dashboard.json (6 hunks)
🔇 Additional comments (3)
dashboard.json (3)
39-39: Score updates look consistent.The score increments (~0.287) appear systematic across all updated entries, maintaining the relative ranking order.
Also applies to: 50-50, 70-70, 81-81, 92-92
132-142: New PR entry is properly structured.The new pull request entry maintains consistent formatting and is correctly positioned based on its score value.
Line range hint
1-600: Overall structure maintains consistency.The JSON structure remains valid with proper ordering of entries by score, and all entries follow the consistent schema pattern.
| { | ||
| "image_url": "https://i.ytimg.com/vi/Hy3-C6V2ir8/hqdefault.jpg", | ||
| "title": "AsyncAPI Conference Dry Run", | ||
| "description": "Setup and conference prep.", | ||
| "videoId": "Hy3-C6V2ir8" | ||
| }, |
There was a problem hiding this comment.
💡 Codebase verification
Update the video entry format to match the established pattern
Based on the meetings.json and newsroom_videos.json content, the Conference Dry Run entry should be updated to:
- Title: "AsyncAPI Conference Dry Run, 16:00 UTC Friday October 18th 2024"
- Description: "AsyncAPI Online Conference 2024 Dry-Run, 16:00 UTC Friday October 18th 2024 community#1559."
All other video entries follow this consistent format with date, time, and GitHub issue reference. The corresponding meeting entry in meetings.json confirms these details.
🔗 Analysis chain
Verify the description format consistency.
While the JSON structure is valid and the video references are correct, the description format differs from other entries in the file. Other entries typically include:
- Date and time information
- A GitHub issue reference
Consider updating the description to match the established pattern if this is a recorded meeting.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if there's a corresponding GitHub issue for this video
# that should be referenced in the description
# Search for any issues mentioning the Conference Dry Run
rg -i "conference.*dry.*run" --glob "*.{md,json}"
Length of output: 256
Script:
#!/bin/bash
# Let's check the content of meetings.json to see if we can find more context
cat config/meetings.json
Length of output: 7932
Script:
#!/bin/bash
# Let's check the format of other entries in newsroom_videos.json for comparison
cat config/newsroom_videos.json
Length of output: 1255
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3341--asyncapi-website.netlify.app/ |
asyncapi-bot
deleted the
update-meetings/7753444299abdb99797fe6097a5683b0d6c13f2a
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3341 +/- ##
=======================================
Coverage 49.14% 49.14%
=======================================
Files 21 21
Lines 647 647
=======================================
Hits 318 318
Misses 329 329 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Updates