-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search history consistency issue #3703
Conversation
Fixes asyncapi#3676 Update search functionality to make search history consistent between search bar and search icon. * Update `AlgoliaModal` component in `components/AlgoliaSearch.tsx` to use `INDEX_NAME` for both search placeholders and index name. * Update `SearchButton` component in `components/navigation/DocsNavWrapper.tsx` to use `INDEX_NAME` for searching resources. * Update `SearchButton` component in `components/navigation/DocsMobileMenu.tsx` to use `INDEX_NAME` for searching resources. * Update `SearchButton` component in `components/navigation/NavBar.tsx` to use `INDEX_NAME` for searching resources. * Update `SearchButton` component in `components/navigation/MobileNavMenu.tsx` to use `INDEX_NAME` for searching resources.
Caution Review failedThe pull request is closed. WalkthroughThis pull request centralizes the search index configuration across components. In the AlgoliaSearch component, the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
We require all PRs to follow Conventional Commits specification.
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fixes #3676
Update search functionality to make search history consistent between search bar and search icon.
AlgoliaModal
component incomponents/AlgoliaSearch.tsx
to useINDEX_NAME
for both search placeholders and index name.SearchButton
component incomponents/navigation/DocsNavWrapper.tsx
to useINDEX_NAME
for searching resources.SearchButton
component incomponents/navigation/DocsMobileMenu.tsx
to useINDEX_NAME
for searching resources.SearchButton
component incomponents/navigation/NavBar.tsx
to useINDEX_NAME
for searching resources.SearchButton
component incomponents/navigation/MobileNavMenu.tsx
to useINDEX_NAME
for searching resources.Summary by CodeRabbit