fix: add Specification Explorer to mobile dropdown and unify Migration spelling (#3727) #3731
Conversation
rathoretaruncodes
requested review from
derberg,
akshatnema,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThis commit updates the navigation learning items by adding a new entry for "Specification Explorer." The update includes importing the required icon component ( Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/navigation/learningItems.tsx(3 hunks)
🧰 Additional context used
🪛 ESLint
components/navigation/learningItems.tsx
[error] 1-10: Run autofix to sort these imports!
(simple-import-sort/imports)
[error] 75-75: Delete ,
(prettier/prettier)
[error] 75-75: Unexpected trailing comma.
(comma-dangle)
🪛 GitHub Actions: PR testing - if Node project
components/navigation/learningItems.tsx
[error] 1-1: Run autofix to sort these imports! simple-import-sort/imports
[error] 75-75: Delete , prettier/prettier
[error] 75-75: Unexpected trailing comma. comma-dangle
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (2)
components/navigation/learningItems.tsx (2)
60-60: LGTM! Consistent terminology.The title change from 'Migrations' to 'Migration' aligns with the PR objective to standardize terminology and matches the URL path.
70-75: LGTM! Well-structured addition.The new Specification Explorer learning item follows the established pattern and provides clear, informative content. The addition aligns with the PR objective to improve navigation accessibility.
🧰 Tools
🪛 ESLint
[error] 75-75: Delete
,(prettier/prettier)
[error] 75-75: Unexpected trailing comma.
(comma-dangle)
🪛 GitHub Actions: PR testing - if Node project
[error] 75-75: Delete
,prettier/prettier
[error] 75-75: Unexpected trailing comma. comma-dangle
| icon: IconExplorer, | ||
| className: 'bg-teal-200', | ||
| title: 'Specification Explorer', | ||
| description: 'Simplifying our Specification JSON Schema like a pro.', |
There was a problem hiding this comment.
Fix trailing comma.
Remove the trailing comma to resolve linting errors.
Apply this diff to fix the trailing comma:
title: 'Specification Explorer',
- description: 'Simplifying our Specification JSON Schema like a pro.',
+ description: 'Simplifying our Specification JSON Schema like a pro.'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| description: 'Simplifying our Specification JSON Schema like a pro.', | |
| title: 'Specification Explorer', | |
| description: 'Simplifying our Specification JSON Schema like a pro.' |
🧰 Tools
🪛 ESLint
[error] 75-75: Delete ,
(prettier/prettier)
[error] 75-75: Unexpected trailing comma.
(comma-dangle)
🪛 GitHub Actions: PR testing - if Node project
[error] 75-75: Delete , prettier/prettier
[error] 75-75: Unexpected trailing comma. comma-dangle
| @@ -7,6 +7,7 @@ | |||
| import IconPlant from '../icons/Plant'; | |||
| import IconRocket from '../icons/Rocket'; | |||
| import IconUsers from '../icons/Users'; | |||
| import IconExplorer from '../icons/Explorer'; | |||
There was a problem hiding this comment.
Fix import sorting.
The import statements need to be sorted according to the project's linting rules.
Apply this diff to fix the import sorting:
import type React from 'react';
+import IconExplorer from '../icons/Explorer';
import IconGradCap from '../icons/GradCap';
import IconGuide from '../icons/Guide';
import IconMigration from '../icons/Migration';
import IconPaper from '../icons/Paper';
import IconPlant from '../icons/Plant';
import IconRocket from '../icons/Rocket';
import IconUsers from '../icons/Users';
-import IconExplorer from '../icons/Explorer';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import IconExplorer from '../icons/Explorer'; | |
| import type React from 'react'; | |
| import IconExplorer from '../icons/Explorer'; | |
| import IconGradCap from '../icons/GradCap'; | |
| import IconGuide from '../icons/Guide'; | |
| import IconMigration from '../icons/Migration'; | |
| import IconPaper from '../icons/Paper'; | |
| import IconPlant from '../icons/Plant'; | |
| import IconRocket from '../icons/Rocket'; | |
| import IconUsers from '../icons/Users'; |
🧰 Tools
🪛 ESLint
[error] 1-10: Run autofix to sort these imports!
(simple-import-sort/imports)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3731 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
|
Thanks @rathoretaruncodes |
|
Hi @anshgoyalevil @antoniogarrote @scharrier @devilkiller-ag , I understand that the author's PR was merged instead of mine. However, I would like to highlight a few points:
I believe that considering contributions from all community members can be beneficial for the project. Please let me know how we can improve this process. Thanks, |
|
@rathoretaruncodes why do you think that opening a PR on an issue that was spotted by someone else would be prioritized over the PR that was created by the author of that issue after approval from the maintainers? Spotting an issue is as important as resolving it. You cannot just create a PR for the issue opened by someone else who is willing to work on it. |
|
@anshgoyalevil @antoniogarrote @scharrier @devilkiller-ag @derberg Why do I think my issue should've been merged?
Also, No one was approved/ assigned for this issue in particular
|
Related issue(s)
Fixes #3727
Description
Screenshots
Desktop:
Mobile:
Summary by CodeRabbit
New Features
Refactor