-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docstrings in scripts files #3770
base: migrate-scripts
Are you sure you want to change the base?
Conversation
Docstrings generation was requested by @akshatnema. * #3761 (comment) The following files were modified: * `scripts/adopters/index.ts` * `scripts/build-docs.ts` * `scripts/build-meetings.ts` * `scripts/build-newsroom-videos.ts` * `scripts/build-pages.ts` * `scripts/build-post-list.ts` * `scripts/build-rss.ts` * `scripts/build-tools.ts` * `scripts/casestudies/index.ts` * `scripts/compose.ts` * `scripts/dashboard/build-dashboard.ts` * `scripts/finance/index.ts` * `scripts/index.ts` * `scripts/markdown/check-edit-links.ts` * `scripts/markdown/check-markdown.ts` * `scripts/tools/combine-tools.ts` * `scripts/tools/extract-tools-github.ts` * `scripts/tools/tools-object.ts` * `scripts/utils.ts` * `scripts/utils/readAndWriteJson.ts` * `utils/redirect.ts`
WalkthroughThis pull request updates documentation comments throughout multiple scripts. The changes clarify function behavior, parameter descriptions, return types, and error handling for processes including file conversion, content building, API data retrieval, and markdown validation. A few function signatures have been adjusted to specify explicit return types. No underlying functionality or control flow has been modified. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (21)
🔇 Additional comments (47)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migrate-scripts #3770 +/- ##
=================================================
Coverage 100.00% 100.00%
=================================================
Files 21 21
Lines 667 667
Branches 113 113
=================================================
Hits 667 667 ☔ View full report in Codecov by Sentry. |
migrate-scripts
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Docstrings generation was requested by @akshatnema.
The following files were modified:
scripts/adopters/index.ts
scripts/build-docs.ts
scripts/build-meetings.ts
scripts/build-newsroom-videos.ts
scripts/build-pages.ts
scripts/build-post-list.ts
scripts/build-rss.ts
scripts/build-tools.ts
scripts/casestudies/index.ts
scripts/compose.ts
scripts/dashboard/build-dashboard.ts
scripts/finance/index.ts
scripts/index.ts
scripts/markdown/check-edit-links.ts
scripts/markdown/check-markdown.ts
scripts/tools/combine-tools.ts
scripts/tools/extract-tools-github.ts
scripts/tools/tools-object.ts
scripts/utils.ts
scripts/utils/readAndWriteJson.ts
utils/redirect.ts
These files were ignored
tests/adopters/index.test.js
tests/build-docs/addDocButtons.test.js
tests/build-docs/buildNavTree.test.js
tests/build-docs/convertDocPosts.test.js
tests/build-meetings.test.js
tests/build-newsroom-videos.test.js
tests/build-pages.test.js
tests/build-post-list.test.js
tests/build-rss.test.js
tests/build-tools.test.js
tests/casestudies/index.test.js
tests/dashboard/build-dashboard.test.js
tests/finance/index.test.js
tests/index.test.js
tests/markdown/check-edit-links.test.js
tests/markdown/check-markdown.test.js
tests/readAndWriteJson.test.js
tests/tools/combine-tools.test.js
tests/tools/extract-tools-github.test.js
tests/tools/tools-object.test.js
tests/utils.test.js
These file types are not supported
package.json
scripts/tools/tools-schema.json
tsconfig.json
ℹ️ Note
Summary by CodeRabbit