-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: case studies content setup #921
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-921--asyncapi-website.netlify.app/ |
Co-authored-by: Fran Méndez <[email protected]>
added some updates to Adeo case study major stuff that is missing are examples, but they just need some prep work before they are shared publicly |
@derberg my gift for you: https://gist.github.com/M3lkior/6b9ce2275f32018eebaf9e9f8cd67910 Enjoy and let me know if it is what you expect ! |
@M3lkior it is perfect, I already update the PR with all the examples I think you can start review if I did not write anything wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an you link to me the path of the case studies page on the deploy-preview website ? i don't find it on https://deploy-preview-921--asyncapi-website.netlify.app/
Co-authored-by: Ludovic Dussart <[email protected]>
I think Docs and Tools needs to stay in their current positions. Maybe we can remove the job section and add the case studies section before the Blog section ? |
IMHO it should be in the top navigation. I’d remove Jobs and put it on the footer. The order that I like is Docs, Tools, Community, Case Studies, and Roadmap. Please, before you merge any change, take into account that “Case Studies” is larger than “Jobs” so make sure you test it properly on different screen sizes. |
Nice! neat idea with moving jobs to footer @akshatnema you agree with proposal to have it as @M3lkior and @fmvilas suggest, between community and blog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshatnema ok, so jobs was already in footer, so now removed from top nav and case study added between community and blog. You ok with that?
Yeah, I'm okay with the navbar. But just make sure that you update the Navbar in both Desktop and mobile view. |
@akshatnema I updated it in one place and it is changed everywhere, mobile too. Just checked. Actually writing this command from mobile 😃 ready for final approval folks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my surprise ✨, @derberg made a good layout of a page with correct CSS 😄. So, this time, for further reviews, approving it ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli omg omg omg thanks for spotting it 🤣 it was actually a placeholder as when I created landing page, there was no readme yet. So I linked to Polish disco polo song (music that polish people complain is shit, but when there is a party we dance to it like there is no tomorrow 😆 )
anyway fixed to link to readme section that will be added with this PR
Good thing my autistic eyes miss NOTHING 😎🥸🤪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🚢🚢🚢🚢🚢🚢🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🇮🇹
😃 I'M SO DAMN HAPPY ABOUT THIS ONE 😃 /rtm |
Related to asyncapi/community#187
UI related to #1008
This is a proposal on how I would like us to start collecting case studies/use cases that entire AsyncAPI community could benefit from:
Contents of this PR:
tl;dr the idea is:
casestudy_template.yml
in a form of GitHub issue template (in spec repo) and then volunteers would make sure to transform it into YAML in website repoWhy YAML?
documentation
or other.Important to remember is that this YAML is just the first version. We can, of course, extend it and modify it as much as we can over time. This is just the initial version based on the first case study.
Vision
With a standard way of case study info structure, it should be super easy for anyone to collect case studies and submit them as PR to website repo. We start with 1 case study and in a year from now we have 50 ❤️
Please have a look, and share your opinion. What could be fixed/improved here?
Pinging participants of asyncapi/community#187 and possible interested folks
@nictownsend @abelgomez @jessemenning @Ugbot @fmvilas @alequetzalli @magicmatatjahu @smoya @jonaslagoni
Stuff for later, that I want to leave for contributors to work on is:
use cases
fields in a list, or only example AsyncAPI documents, to make information easy to access