Feature/misc api changes #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the scheduler key used the target model as subkey to order messages that target the same model. Now this subkey is the origin model rather than the target, or in the case of the global scheduler, 0. This doesn't change anythin in practice for the local scheduler since the origin and target models were the same, but for the global scheduler this provides additional guarranties. For instance, if the global scheduler is used to schedule an event targetting model A and then an event targetting model B where the latter triggers a message to A, it is now guarranteed that the first message will get to A before the second.
The API style is now more uniform: both are passed by mutable ref, and only expose accessors. Additionally, the methods that were initially accessed through the scheduler field are now directly implemented on `Context`.
This was probably never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified and more uniform API:
ContextandBuildContextAPIs (both are now passed by &mut for future-proofing),Simulationand aScheduler,