Report an error if a message cannot be delivered #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jauhien
reviewed
Nov 27, 2024
| SIMULATION_OUT_OF_SYNC = 7; | ||
| SIMULATION_BAD_QUERY = 8; | ||
| SIMULATION_TIME_OUT_OF_RANGE = 9; | ||
| SIMULATION_NO_RECIPIENT = 5; |
There was a problem hiding this comment.
I understand that after final release those numbers will be frozen. Or we do not care about such things?
There was a problem hiding this comment.
Yes, they need to be frozen. They are totally arbitrary though, but at least at the beginning let's order them sequentially...
| tonic::Response<super::ScheduleEventReply>, | ||
| tonic::Status, | ||
| >; | ||
| ) -> std::result::Result<tonic::Response<super::ScheduleEventReply>, tonic::Status>; |
There was a problem hiding this comment.
I don't remember whether rustfmt is applied to codegen code. (Asking as change of formatting looks strange a bit)
There was a problem hiding this comment.
I turned off rustfmt for this, the module is declared as:
#[rustfmt::skip]
pub(crate) mod simulation;There was a problem hiding this comment.
Ah, sorry, nie doczytałem (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.