Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace str.format with f-strings #125

Merged
merged 4 commits into from
Dec 22, 2023
Merged

replace str.format with f-strings #125

merged 4 commits into from
Dec 22, 2023

Conversation

Alex23rodriguez
Copy link
Contributor

(and a little bit of black formatting)

@klamann
Copy link
Contributor

klamann commented Dec 8, 2023

please provide PRs with minimal diffs only, otherwise we get into merge conflicts with other PRs. If formatting with black is something we want to do, we should do so in a separate PR. For this PR, only string formatting should be changed and nothing else.

@Alex23rodriguez
Copy link
Contributor Author

Removed formatting

Copy link
Contributor

@klamann klamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found two minor issues, looks good otherwise :)

hooks/pre_gen_project.py Show resolved Hide resolved
tests/version_check.py Outdated Show resolved Hide resolved
@klamann klamann changed the title repalce format with fstrings replace str.format with f-strings Dec 8, 2023
@klamann
Copy link
Contributor

klamann commented Dec 22, 2023

thanks for contributing this :)

@klamann klamann merged commit 66942b2 into master Dec 22, 2023
9 checks passed
@klamann klamann deleted the fstring branch December 22, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants