Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using bdist_wheel so the ci step does not fail anymore #128

Merged
merged 1 commit into from
May 21, 2024

Conversation

ChrsBaur
Copy link
Contributor

@ChrsBaur ChrsBaur commented May 2, 2024

The build step of the ci pipeline is failing.

@ChrsBaur ChrsBaur added the bug Something isn't working label May 2, 2024
@ChrsBaur ChrsBaur requested a review from SimonCW May 2, 2024 10:10
@ChrsBaur ChrsBaur self-assigned this May 2, 2024
@SimonCW
Copy link
Collaborator

SimonCW commented May 16, 2024

I'm a bit confused. I'm not an expert in packaging but python setup.py dist doesn't exist as a command. It should be sdist for a source distribution. I think that would also be the more general case but I'm also fine with bdist_wheel.

In any case, afaik, the whole python setup.py is deprecated and shouldn't be used (https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html). However, I don't know what the current best-practice is.

@SimonCW
Copy link
Collaborator

SimonCW commented May 16, 2024

I'd be fine with merging this for now. However, I think this is an excellent area to improve the template and bake in modern python distribution best-practices! These could be starting points: https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
https://stackoverflow.com/questions/71080546/what-is-the-preferred-way-to-develop-a-python-package-without-using-setup-py

@SimonCW SimonCW merged commit bd92e75 into master May 21, 2024
9 checks passed
@SimonCW SimonCW deleted the bug/fix-build-step branch May 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants