Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment configs for hocon to demonstrate overwriting base config #50

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

carsten-bo
Copy link
Contributor

#38

I will try to make it better understandable on how to use the possibility of hocon to overwrite the base config with different environment configs.

@carsten-bo carsten-bo force-pushed the feature/hocon-environment-configs branch from 719c6da to 8b4fa9c Compare October 22, 2021 12:06
@carsten-bo carsten-bo marked this pull request as ready for review October 22, 2021 14:33
@carsten-bo carsten-bo requested a review from klamann October 22, 2021 14:33
@carsten-bo
Copy link
Contributor Author

@klamann I hope this makes it understandable how hocon can be used for having different environment configurations. I am not sure if the additional information in the readme is really necessary but it might help to understand the purpose of those config files.

Copy link
Contributor

@klamann klamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! providing a dev and prod config to showcase different setups seems like a good idea to me

@klamann klamann merged commit f2dd43f into master Nov 5, 2021
@klamann klamann deleted the feature/hocon-environment-configs branch November 5, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants