Place authentication in importable file for use with test cases placed in multiple files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in multiple files
klamann
reviewed
Nov 24, 2020
klamann
reviewed
Nov 24, 2020
klamann
reviewed
Nov 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 84.49% 84.34% -0.16%
==========================================
Files 6 6
Lines 729 728 -1
==========================================
- Hits 616 614 -2
- Misses 113 114 +1
Continue to review full report at Codecov.
|
|
Hi @klamann |
|
looks fine for me now! |
philipflohr
pushed a commit
to philipflohr/personio-py
that referenced
this pull request
Jan 14, 2021
…d in multiple files (at-gmbh#11) * Place authentication in importable file for use with test cases placed in multiple files * Readd existing tests * Update import statement * Don't use shared_test_data dict, cache retrieval of valid online user * Don't require python3.8 to run the tests * cleanup Co-authored-by: Sebastian Straub <[email protected]>
philipflohr
pushed a commit
to philipflohr/personio-py
that referenced
this pull request
Jan 21, 2021
…d in multiple files (at-gmbh#11) * Place authentication in importable file for use with test cases placed in multiple files * Readd existing tests * Update import statement * Don't use shared_test_data dict, cache retrieval of valid online user * Don't require python3.8 to run the tests * cleanup Co-authored-by: Sebastian Straub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the login part from the rest of the raw api tests.
While there is no real use of this change right now, in the future this can be used to import the authentication information from multiple test locations