Migrate to pydantic v2
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`assets/__init__.py` - Fixed previous commit qa-checks violations.
Signed-off-by: Christopher Grote <[email protected]>
cmgrote
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Have reviewed most of the files (not the generated code in detail — relying on unit tests and integration tests to confirm that bit), and looks great! 👍
Will get it merged into main so that we can do some thorough testing over the coming days prior to a release with all of these updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos:
- [x] Refactor generation to create separate modules for each asset