FT-843: Implement GET operation that takes a list of attributes and relationships #458
+641
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aryamanz29
requested changes
Jan 3, 2025
…h support for when attributes or relationships_attributes are present
Added by mistake
…o maintain consistency
Aryamanz29
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
LGTM!
Make sure when writing integration tests to check real-world scenarios (which I later fixed in my latest commits) ✅
For example, in your previous integration tests, you only tested for [attributes=["name", "qualified_name"] which misses cases for 🧪
related_attributesattributes(usingAtlanField)related_attributes(usingAtlanField)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
ignore_relationships = Falsetoignore_relationships = TrueFeatures:
attributeandrelationships_attributesparams inAssetClient.get_by_qualified_name()andAssetClient.get_by_guid()which usesfluent searchand not the default raw api call