Fix font

[jmercouris]

I can't seem to load fonts from a local resource. It is not allowed.

Not sure how to circumvent this without running our own HTTP server to load the assets. This seems way overboard though. Any ideas @atlas-engineer/atlas ?

[hgluka]

Maybe data URLs could work? We even have a convenient make-data-url function in web-extensions.lisp, although it's not exported.

I don't know if there are any drawbacks performance-wise, though.

[aartaka]

I can't seem to load fonts from a local resource. It is not allowed.

Not sure how to circumvent this without running our own HTTP server to load the assets. This seems way overboard though. Any ideas @atlas-engineer/atlas ?

What Epiphany does is defining their own ephy-resource:// custom theme, which can gain access to the local files. And then they use ephy-resource links to load bundled resources.

Here's a definition:

webkit_web_context_register_uri_scheme (priv->web_context, "ephy-resource",
                                        (WebKitURISchemeRequestCallback)ephy_resource_request_cb,
                                        NULL, NULL);
webkit_security_manager_register_uri_scheme_as_secure (webkit_web_context_get_security_manager (priv->web_context),
                                                       "ephy-resource");

What we can do is:

• Include all the static assets as :static-files with ASDF.
• Define a scheme that's resolve files with ASDF.
• And pack these assets together with Nyxt (should be automatic on Guix, but could be non-trivial elsewhere.)

We can mimic Epiphany with:

(define-internal-scheme "nyxt-resource"
  (lambda (url buffer)
    #|...|#
    (asdf:system-relative-pathname :nyxt (quri:uri-path (url url)))
    #|...|#)
  :secure-p t)

[aartaka]

Maybe data URLs could work? We even have a convenient make-data-url function in web-extensions.lisp, although it's not exported.

I don't know if there are any drawbacks performance-wise, though.

That's a solution we rely on in several places, yes. But it's better to avoid it.

There are several drawbacks, starting with the length restrictions for data: URLs, and up to security risks. So if we have any option to not use data: URLs, then we probably should pick that non-data: option.

[jmercouris]

Thank you for the idea Artyom, I have implemented it! Still not sure about its portability or what asdf:static-file does. Does that mean that the system relative files will be available on a compiled system even if the binary is moved?

[aartaka]

Still not sure about its portability or what asdf:static-file does. Does that mean that the system relative files will be available on a compiled system even if the binary is moved?

I'm not sure either, because our current packaging goes a great length to ship at least the source files alongside Nyxt. Pierre might have a better perspective, because he's the one that implemented this ASDF-based packaging.

[jmercouris]

there's an NASDF file thing, perhaps that can be used. Beyond this, do you think it is ready? (I'll test the flatpak)

[jmercouris]

flatpak failed, have to load the fonts into the image somehow and cache them.

[jmercouris]

I've figured out a strategy for caching the fonts in the image. I will continue to think about it a little bit more before committing.

[aartaka]

Beyond this, do you think it is ready? (I'll test the flatpak)

It works interactively, but I can't make it work when built with Guix. Problem is on my side, most probably. Can someone else test it when built with Guix?

[jmercouris]

The problem is not on your side, static file will not do what we wish. We must load things into the image.

[jmercouris]

@aartaka take a look at my latest commits. For some reason, the *static-data* is populated interactively, but not when compiled... I don't get it :-(

[jmercouris]

@Ambrevar any ideas?

[jmercouris]

note that 5bbc97d does work, but that is no way to do things...

[jmercouris]

I have made it work even portably. Static-files is not the way to go here.

[jmercouris]

I used a merge commit because I want to show the process and show why static files doesn't work, and how it could work. Perhaps someone could pick it up in the future.

[Ambrevar]

Why call it "glyph-logo" and not "nyxt-logo" or "application-logo"?
Does it have to be an SVG?

[jmercouris]

Yes, has to be an SVG. Name was set to be consistent with other glyphs

[Ambrevar]

I suggest we unexport this and instead add a function to get the static data. This would be more future-proof.

[jmercouris]

A good idea!

[Ambrevar]

Why the multiple-value-bind if you are ignoring exists?
This is effectively equivalent to (gethash (quri:uri-path (url url)) *static-data*).

[jmercouris]

I know what you are thinking, but if you remove it, Webkit loses its mind. I didn't add it for no reason :-D

[Ambrevar]

Oh, I see, this is because the callback multiple values have specific expectations for an Internal scheme, see define-internal-scheme documentation.

Anyways, to effectively discard multiple values beside the primary value, use nth-value 0 or prog1.

Done in b3ac06d.

[jmercouris]

I almost used nth value, since I was on the fence, we go with it!