fix withRouter types #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const Component = WrappedComponent as ComponentType<WithRouter & P>; | ||
| const ComponentWithRouter = (props: P) => ( | ||
| const Component = WrappedComponent; | ||
| const ComponentWithRouter = (unknownProps: any) => ( |
There was a problem hiding this comment.
is "unknown" necessary?
MonicaOlejniczak
requested changes
Jun 15, 2020
| const displayName = getWrappedComponentDisplayName(WrappedComponent); | ||
| const Component = WrappedComponent as ComponentType<WithRouter & P>; | ||
| const ComponentWithRouter = (props: P) => ( | ||
| const Component = WrappedComponent; |
There was a problem hiding this comment.
/nit May as well just renamed the WrappedComponent argument to Component?
| const Component = WrappedComponent as ComponentType<WithRouter & P>; | ||
| const ComponentWithRouter = (props: P) => ( | ||
| const Component = WrappedComponent; | ||
| const ComponentWithRouter = (props: any) => ( |
There was a problem hiding this comment.
Why can't you use P anymore over any?
| export type Route = { | ||
| path: string; | ||
| exact?: boolean; | ||
|
|
||
| /** The component to render on match, typed explicitly */ | ||
| component: ComponentType<RouteContext>; | ||
| component: ComponentType<RouteComponentProps> | ComponentType<any>; |
There was a problem hiding this comment.
Could this just be made into an optional generic like in the withRouter case? This should only need to be supported for consumers that do not use the exported RouteComponent component, and I would avoid the use of any here as a result. The default prop type just just be RouteComponentProps for those using the route component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously merged into @atlaskit/router on atlassian-frontend for AKR-23 but didn't get migrated to RRR.