[AXON-17] Fix weird site list behaviour #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdzh-atlassian
requested review from
bwieger-atlassian-com and
cabella-dot
as code owners
sdzh-atlassian
force-pushed
the
AXON-17-site-list-fix
branch
3 times, most recently
from
07415bd to
d2b7f08
Compare
sdzh-atlassian
changed the title
sdzh-atlassian
changed the title
sdzh-atlassian
force-pushed
the
AXON-17-site-list-fix
branch
from
d2b7f08 to
041356e
Compare
sdzh-atlassian
changed the title
sdzh-atlassian
force-pushed
the
AXON-17-site-list-fix
branch
from
041356e to
92bd5e9
Compare
sdzh-atlassian
commented
Feb 6, 2025
| @@ -120,6 +121,10 @@ export interface DetailedSiteInfo extends SiteInfo { | |||
| credentialId: string; | |||
| } | |||
|
|
|||
| export function getSiteInfoKey(site: DetailedSiteInfo): string { | |||
| return `${site.product.key} - ${site.host} - ${site.credentialId}`; | |||
| } | |||
There was a problem hiding this comment.
This bit here is more or less the key to everything - we can't index credential stuff with only credentialId since the credential is shared across all JIRA sites the user has access to when doing 3LO. So, let's use host in addition - and the keyword of jira/bitbucket for good measure ;)
There was a problem hiding this comment.
Good idea on the product key! 🎉
|
Looks like a bug got introduced. Before: When I sign into one site, all my other sites are logged into and all the JQLs work
|
bwieger-atlassian-com
requested changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this
This PR addresses the weird behaviour that happens whenever we try to delete one site from several sharing a credential:
After the change, it's possible to remove the sites individually. However, while working on this, I've found a couple other rather frustrating issues which will require a more comprehensive rework 😢
Specifically:
I've tried addressing these quickly - but since ultimately they are not a priority at the moment, I've left this PR at addressing the actual problem we got reported 😛
How was this tested?
Since this is mainly a UI change - by setting up the extension and clicking around a bunch? 😉