Make it possible to run jmx init container as non root in common chart #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bianchi2
requested review from
nanux,
errcode1202,
yzha645,
jjeongatl,
bconroyA and
ealliaume
as code owners
nanux
reviewed
Sep 16, 2023
| @@ -30,8 +30,15 @@ Jmx init container | |||
| image: {{ .Values.monitoring.jmxExporterImageRepo}}:{{ .Values.monitoring.jmxExporterImageTag}} | |||
| command: ["cp"] | |||
| args: ["/opt/bitnami/jmx-exporter/jmx_prometheus_javaagent.jar", "{{ .Values.volumes.sharedHome.mountPath }}"] | |||
| {{- if .Values.monitoring.jmxExporterInitContainer.runAsRoot }} | |||
There was a problem hiding this comment.
Maybe I am just blind but I can't see the monitoring.jmxExporterInitContainer.runAsRoot and monitoring.jmxExporterInitContainer.customSecurityContext stanza in any of the values.yaml files. Was this just omitted in the PR?
There was a problem hiding this comment.
@nanux the idea is to release common first and then raise a PR with changes to helm charts + unit tests
There was a problem hiding this comment.
I see, that does make sense. Might be just good to indicate in PR description.
nanux
approved these changes
Sep 17, 2023
bianchi2
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #666
When
runAsRootis forbidden in the cluster, the pod can't be scheduled. It does make sense to be able to disable securityContent for the init container, as well as let users define their own securityContext (can't think of cases when container securityContext will differ from the one set in pod spec though).This PR brings changes to the common chart which defines jmx init container. Once merged, a new version will be released, and a new PR to helm charts will be raised with the 2nd portion of changes.
Checklist
e2elabel)